Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: decode option for getRouterParam #556

Merged
merged 7 commits into from
Nov 20, 2023
Merged

feat: decode option for getRouterParam #556

merged 7 commits into from
Nov 20, 2023

Conversation

HigherOrderLogic
Copy link
Contributor

🔗 Linked issue

Closes #547.

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Adding the decode option for getRouterParam and getRouterParams.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov Codecov
Copy link

codecov bot commented Nov 20, 2023 •
edited
Loading

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (fa26af5) 84.07% compared to head (43f9c26) 84.02%.

❗ Current head 43f9c26 differs from pull request most recent head 52a7d02. Consider uploading reports for the commit 52a7d02 to get more accurate results

Files Patch % Lines
src/utils/request.ts 66.66% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #556      +/-   ##
==========================================
- Coverage   84.07%   84.02%   -0.06%     
==========================================
  Files          31       31              
  Lines        3667     3680      +13     
  Branches      544      548       +4     
==========================================
+ Hits         3083     3092       +9     
- Misses        584      588       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pi0
pi0 approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️

@pi0 pi0 changed the title feat: decode param option for getRouterParam feat: decode option for getRouterParam Nov 20, 2023
@pi0 pi0 merged commit c28efd2 into unjs:main Nov 20, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support optional decoding for getRouterParam
2 participants
@HigherOrderLogic @pi0